Add error logging to awp-cli with configurable log file

- Route all log output to AWP_LOG_FILE (from .env) if set, else stderr
- Log errors explicitly before returning so they appear in the log file
- Replace log.Fatal in fetch.go with proper error return so callers control logging
- Remove chatty success/no-op log lines that would bloat cron log files

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Harry Culpan 2026-06-30 16:45:56 -04:00
parent 04f687a278
commit 713a96501d
3 changed files with 19 additions and 24 deletions

View file

@ -65,19 +65,16 @@ var checkCmd = &cobra.Command{
emails sent by players to indicate if they emails sent by players to indicate if they
will attend the next session.`, will attend the next session.`,
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
log.Default().Println("Checking for emails")
emails, err := email.FetchEmails() emails, err := email.FetchEmails()
if err != nil { if err != nil {
log.Default().Printf("ERROR fetching emails: %s", err)
return err return err
} }
if len(emails) == 0 { if len(emails) > 0 {
log.Default().Println("No new emails")
} else {
log.Default().Println("Reading new emails")
session, err := data.ReadSessionData() session, err := data.ReadSessionData()
if err != nil { if err != nil {
log.Default().Println(err) log.Default().Printf("ERROR reading session data: %s", err)
return err return err
} }

View file

@ -1,26 +1,32 @@
/*
Copyright © 2024 NAME HERE <EMAIL ADDRESS>
*/
package cmd package cmd
import ( import (
"fmt"
"log"
"os" "os"
"github.com/joho/godotenv"
"github.com/spf13/cobra" "github.com/spf13/cobra"
) )
// rootCmd represents the base command when called without any subcommands
var rootCmd = &cobra.Command{ var rootCmd = &cobra.Command{
Use: "awp-cli", Use: "awp-cli",
Short: "CLI utility for Are We Playing? web app", Short: "CLI utility for Are We Playing? web app",
Long: `CLI utility for Are We Playing? web app`, Long: `CLI utility for Are We Playing? web app`,
// Uncomment the following line if your bare application PersistentPreRunE: func(cmd *cobra.Command, args []string) error {
// has an action associated with it: godotenv.Load()
// Run: func(cmd *cobra.Command, args []string) { }, logFile := os.Getenv("AWP_LOG_FILE")
if len(logFile) > 0 {
f, err := os.OpenFile(logFile, os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0644)
if err != nil {
return fmt.Errorf("unable to open log file %s: %w", logFile, err)
}
log.SetOutput(f)
}
return nil
},
} }
// Execute adds all child commands to the root command and sets flags appropriately.
// This is called by main.main(). It only needs to happen once to the rootCmd.
func Execute() { func Execute() {
err := rootCmd.Execute() err := rootCmd.Execute()
if err != nil { if err != nil {
@ -30,13 +36,5 @@ func Execute() {
func init() { func init() {
rootCmd.CompletionOptions.DisableDefaultCmd = true rootCmd.CompletionOptions.DisableDefaultCmd = true
// Here you will define your flags and configuration settings.
// Cobra supports persistent flags, which, if defined here,
// will be global for your application.
// rootCmd.PersistentFlags().StringVar(&cfgFile, "config", "", "config file (default is $HOME/.cli.yaml)")
// Cobra also supports local flags, which will only run
// when this action is called directly.
rootCmd.Flags().BoolP("toggle", "t", false, "Help message for toggle") rootCmd.Flags().BoolP("toggle", "t", false, "Help message for toggle")
} }

View file

@ -19,7 +19,7 @@ func FetchEmails() ([]Email, error) {
imapClient, err := config.ConnectToServer(IMAP_SERVICE) imapClient, err := config.ConnectToServer(IMAP_SERVICE)
if err != nil { if err != nil {
log.Fatal(err) return nil, err
} }
defer imapClient.Logout() defer imapClient.Logout()