From fc5c986141743bcaefde3e3c099f27db3b520af2 Mon Sep 17 00:00:00 2001 From: Harry Culpan Date: Tue, 30 Jun 2026 19:57:46 -0400 Subject: [PATCH] Consolidate log file env vars: AWP_LOG_FILE (web) and AWP_CLI_LOG_FILE (CLI) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Removes the duplicate log setup from cli/cmd/root.go that was reading AWP_LOG_FILE — log file config now lives only in each binary's main.go. Co-Authored-By: Claude Sonnet 4.6 --- cmd/cli/cmd/root.go | 10 ---------- cmd/cli/main.go | 2 +- cmd/web/main.go | 2 +- 3 files changed, 2 insertions(+), 12 deletions(-) diff --git a/cmd/cli/cmd/root.go b/cmd/cli/cmd/root.go index 0d6e1fb..8eeca88 100644 --- a/cmd/cli/cmd/root.go +++ b/cmd/cli/cmd/root.go @@ -1,8 +1,6 @@ package cmd import ( - "fmt" - "log" "os" "github.com/joho/godotenv" @@ -15,14 +13,6 @@ var rootCmd = &cobra.Command{ Long: `CLI utility for Are We Playing? web app`, PersistentPreRunE: func(cmd *cobra.Command, args []string) error { godotenv.Load() - logFile := os.Getenv("AWP_LOG_FILE") - if len(logFile) > 0 { - f, err := os.OpenFile(logFile, os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0644) - if err != nil { - return fmt.Errorf("unable to open log file %s: %w", logFile, err) - } - log.SetOutput(f) - } return nil }, } diff --git a/cmd/cli/main.go b/cmd/cli/main.go index 5703be6..f01e6d3 100644 --- a/cmd/cli/main.go +++ b/cmd/cli/main.go @@ -14,7 +14,7 @@ import ( func main() { godotenv.Load() - logFile := os.Getenv("CLI_LOG_FILE") + logFile := os.Getenv("AWP_CLI_LOG_FILE") if len(logFile) > 0 { utils.SetLogFile(logFile) } diff --git a/cmd/web/main.go b/cmd/web/main.go index 72a33eb..4e159f4 100644 --- a/cmd/web/main.go +++ b/cmd/web/main.go @@ -28,7 +28,7 @@ func main() { log.Fatal("unable to load APP_KEY") } - logFile := os.Getenv("WEB_LOG_FILE") + logFile := os.Getenv("AWP_LOG_FILE") if len(logFile) > 0 { utils.SetLogFile(logFile) }